]> www.infradead.org Git - nvme.git/commitdiff
nfs: Add missing release on error in nfs_lock_and_join_requests()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 2 Apr 2025 11:02:40 +0000 (14:02 +0300)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 2 Apr 2025 13:53:16 +0000 (09:53 -0400)
Call nfs_release_request() on this error path before returning.

Fixes: c3f2235782c3 ("nfs: fold nfs_folio_find_and_lock_request into nfs_lock_and_join_requests")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/3aaaa3d5-1c8a-41e4-98c7-717801ddd171@stanley.mountain
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/write.c

index aa3d8bea3ec06126d31e2a4eb525b43f3070a5bf..23df8b214474f4e142b14c86c1c96427c8cd2107 100644 (file)
@@ -579,8 +579,10 @@ retry:
 
        while (!nfs_lock_request(head)) {
                ret = nfs_wait_on_request(head);
-               if (ret < 0)
+               if (ret < 0) {
+                       nfs_release_request(head);
                        return ERR_PTR(ret);
+               }
        }
 
        /* Ensure that nobody removed the request before we locked it */