]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/xe/pf: Disable VFs on remove
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 26 Jun 2024 11:18:26 +0000 (13:18 +0200)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 26 Jun 2024 22:25:35 +0000 (18:25 -0400)
We shouldn't leave VFs enabled when unloading the PF driver.
Otherwise we will get a message like:

 [ ] xe 0000:4d:00.0: driver left SR-IOV enabled after remove

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240626111827.1389-2-michal.wajdeczko@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_pci.c

index 21a1b7d2b2a94b0e5e67cddbc389cff8e3d95096..f5d5a368e5959b6bbfef54b79dc7cb1f4226e9c5 100644 (file)
@@ -748,6 +748,11 @@ static void xe_pci_remove(struct pci_dev *pdev)
        if (!xe) /* driver load aborted, nothing to cleanup */
                return;
 
+#ifdef CONFIG_PCI_IOV
+       if (IS_SRIOV_PF(xe))
+               xe_pci_sriov_configure(pdev, 0);
+#endif
+
        xe_device_remove(xe);
        xe_pm_runtime_fini(xe);
        pci_set_drvdata(pdev, NULL);