iwlwifi: mvm: drop too short packets silently

There's little value in this warning, we get a warning here
if firmware passes us a short packet, particularly in monitor
mode.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20211219132536.305d12cf51ac.I2e4e6874113b1e5d8ee467b8a2d90820cc6ddde9@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
index c8b20f202627889f2405a1fc0da9a152e79394e6..295629c5c0350600f6aa0dcf6aec5800f0b0cc04 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
@@ -176,18 +176,8 @@ static int iwl_mvm_create_skb(struct iwl_mvm *mvm, struct sk_buff *skb,
         */
        hdrlen += crypt_len;
 
-       if (WARN_ONCE(headlen < hdrlen,
-                     "invalid packet lengths (hdrlen=%d, len=%d, crypt_len=%d)\n",
-                     hdrlen, len, crypt_len)) {
-               /*
-                * We warn and trace because we want to be able to see
-                * it in trace-cmd as well.
-                */
-               IWL_DEBUG_RX(mvm,
-                            "invalid packet lengths (hdrlen=%d, len=%d, crypt_len=%d)\n",
-                            hdrlen, len, crypt_len);
+       if (unlikely(headlen < hdrlen))
                return -EINVAL;
-       }
 
        skb_put_data(skb, hdr, hdrlen);
        skb_put_data(skb, (u8 *)hdr + hdrlen + pad_len, headlen - hdrlen);