media: platform: fix missing/incorrect resource cleanup in error case

In error case of s5p_mfc_power_on() we should call
clk_disable_unprepare() for the
clocks(from pm->clocks[0] to pm->clocks[i-1]).

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
index 72a901e9945039edb352b3b317a3fed3f7e539d0..187849841a28b28f0a204ebb38e2ebcbe22228aa 100644 (file)
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c
@@ -88,7 +88,6 @@ int s5p_mfc_power_on(void)
                if (ret < 0) {
                        mfc_err("clock prepare failed for clock: %s\n",
                                pm->clk_names[i]);
-                       i++;
                        goto err;
                }
        }
@@ -98,7 +97,7 @@ int s5p_mfc_power_on(void)
 
        return 0;
 err:
-       while (--i > 0)
+       while (--i >= 0)
                clk_disable_unprepare(pm->clocks[i]);
        pm_runtime_put(pm->device);
        return ret;