]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Fix potential NULL dereference in Java example code
authorDavid Woodhouse <dwmw2@infradead.org>
Wed, 28 Apr 2021 20:18:30 +0000 (21:18 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Wed, 28 Apr 2021 20:18:30 +0000 (21:18 +0100)
Coverity tells us that getline() can return null. Don't blindly reference
it.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
java/src/com/example/LibTest.java

index d2097ca2adb0dfb5576cb6905817589fa65f5828..52fcd7089f9f0315af5c65c0589bf1171dbf7940 100644 (file)
@@ -55,7 +55,7 @@ public final class LibTest {
 
                        System.out.print("\nAccept this certificate? [n] ");
                        String s = getline();
-                       if (s.startsWith("y") || s.startsWith("Y")) {
+                       if (s != null && (s.startsWith("y") || s.startsWith("Y"))) {
                                return 0;
                        } else {
                                return -1;