]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
writeback: factor out balance_domain_limits to remove repeated code
authorKemeng Shi <shikemeng@huaweicloud.com>
Tue, 14 May 2024 12:52:52 +0000 (20:52 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 4 Jul 2024 02:29:54 +0000 (19:29 -0700)
Factor out balance_domain_limits to remove repeated code.

Link: https://lkml.kernel.org/r/20240514125254.142203-7-shikemeng@huaweicloud.com
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page-writeback.c

index a93505cadd4ee8241682fcd7b8a5eab00a8a1969..e03beb95a62e79f7056cc53e1c65cb93a00edd0e 100644 (file)
@@ -1746,6 +1746,14 @@ static void domain_dirty_freerun(struct dirty_throttle_control *dtc,
        dtc->freerun = dirty <= dirty_freerun_ceiling(thresh, bg_thresh);
 }
 
+static void balance_domain_limits(struct dirty_throttle_control *dtc,
+                                 bool strictlimit)
+{
+       domain_dirty_avail(dtc, true);
+       domain_dirty_limits(dtc);
+       domain_dirty_freerun(dtc, strictlimit);
+}
+
 static void wb_dirty_freerun(struct dirty_throttle_control *dtc,
                             bool strictlimit)
 {
@@ -1802,18 +1810,13 @@ static int balance_dirty_pages(struct bdi_writeback *wb,
 
                nr_dirty = global_node_page_state(NR_FILE_DIRTY);
 
-               domain_dirty_avail(gdtc, true);
-               domain_dirty_limits(gdtc);
-               domain_dirty_freerun(gdtc, strictlimit);
-
+               balance_domain_limits(gdtc, strictlimit);
                if (mdtc) {
                        /*
                         * If @wb belongs to !root memcg, repeat the same
                         * basic calculations for the memcg domain.
                         */
-                       domain_dirty_avail(mdtc, true);
-                       domain_dirty_limits(mdtc);
-                       domain_dirty_freerun(mdtc, strictlimit);
+                       balance_domain_limits(mdtc, strictlimit);
                }
 
                /*