]> www.infradead.org Git - users/hch/xfs.git/commitdiff
net: ethernet: mtk-star-emac: set mac_managed_pm when probing
authorJian Hui Lee <jianhui.lee@canonical.com>
Mon, 8 Jul 2024 06:52:09 +0000 (14:52 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 11 Jul 2024 08:13:28 +0000 (10:13 +0200)
The below commit introduced a warning message when phy state is not in
the states: PHY_HALTED, PHY_READY, and PHY_UP.
commit 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")

mtk-star-emac doesn't need mdiobus suspend/resume. To fix the warning
message during resume, indicate the phy resume/suspend is managed by the
mac when probing.

Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
Signed-off-by: Jian Hui Lee <jianhui.lee@canonical.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20240708065210.4178980-1-jianhui.lee@canonical.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mediatek/mtk_star_emac.c

index 31aebeb2e285854833e98768a80bca7b93c4873d..25989c79c92e612eec241d175f4789018f520a8f 100644 (file)
@@ -1524,6 +1524,7 @@ static int mtk_star_probe(struct platform_device *pdev)
 {
        struct device_node *of_node;
        struct mtk_star_priv *priv;
+       struct phy_device *phydev;
        struct net_device *ndev;
        struct device *dev;
        void __iomem *base;
@@ -1649,6 +1650,12 @@ static int mtk_star_probe(struct platform_device *pdev)
        netif_napi_add(ndev, &priv->rx_napi, mtk_star_rx_poll);
        netif_napi_add_tx(ndev, &priv->tx_napi, mtk_star_tx_poll);
 
+       phydev = of_phy_find_device(priv->phy_node);
+       if (phydev) {
+               phydev->mac_managed_pm = true;
+               put_device(&phydev->mdio.dev);
+       }
+
        return devm_register_netdev(dev, ndev);
 }