]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1()
authorDouglas Anderson <dianders@chromium.org>
Wed, 29 Nov 2023 21:25:23 +0000 (13:25 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Dec 2023 12:22:01 +0000 (12:22 +0000)
Delay loops in r8152 should break out if RTL8152_INACCESSIBLE is set
so that they don't delay too long if the device becomes
inaccessible. Add the break to the loop in r8153_pre_firmware_1().

Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153")
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index c4dd81e2421fc007aa0d3faaf1d6705539f3a77e..3958eb622d4731f51e9bd3d3e2bc02fbc1d8e20e 100644 (file)
@@ -5645,6 +5645,8 @@ static int r8153_pre_firmware_1(struct r8152 *tp)
        for (i = 0; i < 104; i++) {
                u32 ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_WDT1_CTRL);
 
+               if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
+                       return -ENODEV;
                if (!(ocp_data & WTD1_EN))
                        break;
                usleep_range(1000, 2000);