selftests/bpf: Fix incorrect ASSERT in the tcp_hdr_options test

[ Upstream commit 52929912d7bda040b43538e8d88e8d231b76eb4e ]

This patch fixes the incorrect ASSERT test in tcp_hdr_options during
the CHECK to ASSERT macro cleanup.

Fixes: 3082f8cd4ba3 ("selftests/bpf: Convert tcp_hdr_options test to ASSERT_* macros")
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Wang Yufen <wangyufen@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20221107230420.4192307-3-martin.lau@linux.dev
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
index 617bbce6ef8f13de8846398b734dcffb8e8dbaaa..57191773572a0515f108594abf638d4ed136c58a 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
+++ b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
@@ -485,7 +485,7 @@ static void misc(void)
                        goto check_linum;
 
                ret = read(sk_fds.passive_fd, recv_msg, sizeof(recv_msg));
-               if (ASSERT_EQ(ret, sizeof(send_msg), "read(msg)"))
+               if (!ASSERT_EQ(ret, sizeof(send_msg), "read(msg)"))
                        goto check_linum;
        }
 
@@ -539,7 +539,7 @@ void test_tcp_hdr_options(void)
                goto skel_destroy;
 
        cg_fd = test__join_cgroup(CG_NAME);
-       if (ASSERT_GE(cg_fd, 0, "join_cgroup"))
+       if (!ASSERT_GE(cg_fd, 0, "join_cgroup"))
                goto skel_destroy;
 
        for (i = 0; i < ARRAY_SIZE(tests); i++) {