RDMA/bnxt_re: Remove unnecessary checks

The NULL check inside bnxt_qplib_del_sgid() and bnxt_qplib_add_sgid()
always return false as the "sgid_tbl" inside "rdev->qplib_res" is a static
memory.

Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Link: https://lore.kernel.org/r/1684478897-12247-8-git-send-email-selvin.xavier@broadcom.com
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index 1714a1e231132fcf3b6eee90ca03277475d88d7a..dbb0e4e9254db3ce6177cd4f7d797ed635119fe5 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -233,10 +233,6 @@ int bnxt_qplib_del_sgid(struct bnxt_qplib_sgid_tbl *sgid_tbl,
        struct bnxt_qplib_rcfw *rcfw = res->rcfw;
        int index;
 
-       if (!sgid_tbl) {
-               dev_err(&res->pdev->dev, "SGID table not allocated\n");
-               return -EINVAL;
-       }
        /* Do we need a sgid_lock here? */
        if (!sgid_tbl->active) {
                dev_err(&res->pdev->dev, "SGID table has no active entries\n");
@@ -297,10 +293,6 @@ int bnxt_qplib_add_sgid(struct bnxt_qplib_sgid_tbl *sgid_tbl,
        struct bnxt_qplib_rcfw *rcfw = res->rcfw;
        int i, free_idx;
 
-       if (!sgid_tbl) {
-               dev_err(&res->pdev->dev, "SGID table not allocated\n");
-               return -EINVAL;
-       }
        /* Do we need a sgid_lock here? */
        if (sgid_tbl->active == sgid_tbl->max) {
                dev_err(&res->pdev->dev, "SGID table is full\n");