]> www.infradead.org Git - users/borneoa/openocd-next.git/commitdiff
target: improve error messaging in `target create`
authorEvgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Mon, 28 Apr 2025 13:46:08 +0000 (16:46 +0300)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 9 May 2025 12:12:04 +0000 (12:12 +0000)
There are a couple of issues with the usage string for `target create`,
namely:
* `-chain-position` is allowed to be not the first option.
* `-chain-position` should be ommited alltogether on ARM targets when
  DAP is specified.

Before the patch:
```
> openocd -c 'target create name testee'
...
  target create name type '-chain-position' name [options ...]
```

After the patch:
```
> openocd -c 'target create name testee'
...
-chain-position ?name? required when creating target
> openocd -c 'target create'
...
  target create name type [options ...]
```

Change-Id: Ia21a99ce6a4086e2e0676f5ef4685da3514a4f69
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8860
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/target/target.c

index a85d3def85f2c9b335eae67e8ddeea19ba2882c9..6d2fc95060e76dce48fe2edaba4e4d32087a9c9f 100644 (file)
@@ -5706,7 +5706,7 @@ COMMAND_HANDLER(handle_target_create)
        int retval = ERROR_OK;
        int x;
 
-       if (CMD_ARGC < 4)
+       if (CMD_ARGC < 2)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
        /* check if the target name clashes with an existing command name */
@@ -6051,7 +6051,7 @@ static const struct command_registration target_subcommand_handlers[] = {
                .name = "create",
                .mode = COMMAND_CONFIG,
                .handler = handle_target_create,
-               .usage = "name type '-chain-position' name [options ...]",
+               .usage = "name type [options ...]",
                .help = "Creates and selects a new target",
        },
        {