]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Input: tc3589x - use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:52 +0000 (13:12 -0600)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 31 Jul 2024 19:36:49 +0000 (12:36 -0700)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-14-robh@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/tc3589x-keypad.c

index b0d86621c60a330f42e508bae6c2db8677794363..11988cffdfae8c5004051e8c80f5c8994d0a23b3 100644 (file)
@@ -325,7 +325,6 @@ tc3589x_keypad_of_probe(struct device *dev)
        struct tc3589x_keypad_platform_data *plat;
        u32 cols, rows;
        u32 debounce_ms;
-       int proplen;
 
        if (!np)
                return ERR_PTR(-ENODEV);
@@ -346,7 +345,7 @@ tc3589x_keypad_of_probe(struct device *dev)
                return ERR_PTR(-EINVAL);
        }
 
-       if (!of_get_property(np, "linux,keymap", &proplen)) {
+       if (!of_property_present(np, "linux,keymap")) {
                dev_err(dev, "property linux,keymap not found\n");
                return ERR_PTR(-ENOENT);
        }