]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
qla2xxx: Remove redundant NULL check before release_firmware() call.
authorJesper Juhl <jj@chaosbits.net>
Thu, 12 Apr 2012 20:37:41 +0000 (15:37 -0500)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Mon, 23 Jul 2012 08:02:44 +0000 (01:02 -0700)
release_firmware() checks for NULL pointers internally so checking before calling it is redundant.

JIRA Key: V2632FC-196

drivers/scsi/qla2xxx/qla_os.c

index 9c884a7506dee489a22172812b153575c38bb863..d897b3ad34f3f2d936d626716070870e80d43050 100644 (file)
@@ -4137,8 +4137,7 @@ qla2x00_release_firmware(void)
 
        mutex_lock(&qla_fw_lock);
        for (idx = 0; idx < FW_BLOBS; idx++)
-               if (qla_fw_blobs[idx].fw)
-                       release_firmware(qla_fw_blobs[idx].fw);
+               release_firmware(qla_fw_blobs[idx].fw);
        mutex_unlock(&qla_fw_lock);
 }