]> www.infradead.org Git - users/willy/xarray.git/commitdiff
powerpc: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:47 +0000 (13:12 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 7 Aug 2024 12:48:26 +0000 (22:48 +1000)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240731191312.1710417-9-robh@kernel.org
arch/powerpc/platforms/powernv/eeh-powernv.c
arch/powerpc/platforms/powernv/opal-lpc.c

index af3a5d37a1496a2d1dcb51c53ad6ff5dd6df646c..3d072a7455bf6628f40320a6de3aa46572be6394 100644 (file)
@@ -860,7 +860,7 @@ static int pnv_eeh_bridge_reset(struct pci_dev *pdev, int option)
        int64_t rc;
 
        /* Hot reset to the bus if firmware cannot handle */
-       if (!dn || !of_get_property(dn, "ibm,reset-by-firmware", NULL))
+       if (!dn || !of_property_present(dn, "ibm,reset-by-firmware"))
                return __pnv_eeh_bridge_reset(pdev, option);
 
        pr_debug("%s: FW reset PCI bus %04x:%02x with option %d\n",
index a16f07cdab267c5107dc650b41fc06b1cb335592..8a7f39e106bdbb2b98e1c68d00ca2a92c29d38a4 100644 (file)
@@ -393,7 +393,7 @@ void __init opal_lpc_init(void)
        for_each_compatible_node(np, NULL, "ibm,power8-lpc") {
                if (!of_device_is_available(np))
                        continue;
-               if (!of_get_property(np, "primary", NULL))
+               if (!of_property_present(np, "primary"))
                        continue;
                opal_lpc_chip_id = of_get_ibm_chip_id(np);
                of_node_put(np);