]> www.infradead.org Git - users/hch/misc.git/commitdiff
tpm_tis: Fix incorrect arguments in tpm_tis_probe_irq_single
authorGunnar Kudrjavets <gunnarku@amazon.com>
Thu, 18 Sep 2025 15:49:40 +0000 (18:49 +0300)
committerJarkko Sakkinen <jarkko@kernel.org>
Fri, 10 Oct 2025 05:21:45 +0000 (08:21 +0300)
The tpm_tis_write8() call specifies arguments in wrong order. Should be
(data, addr, value) not (data, value, addr). The initial correct order
was changed during the major refactoring when the code was split.

Fixes: 41a5e1cf1fe1 ("tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy")
Signed-off-by: Gunnar Kudrjavets <gunnarku@amazon.com>
Reviewed-by: Justinien Bouron <jbouron@amazon.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_tis_core.c

index 4b12c4b9da8befc4a284e5ecf433d71e738ae3a7..8954a8660ffc5a2b6627f614bf22dfc2868e0298 100644 (file)
@@ -978,8 +978,8 @@ restore_irqs:
         * will call disable_irq which undoes all of the above.
         */
        if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) {
-               tpm_tis_write8(priv, original_int_vec,
-                              TPM_INT_VECTOR(priv->locality));
+               tpm_tis_write8(priv, TPM_INT_VECTOR(priv->locality),
+                              original_int_vec);
                rc = -1;
        }