nvme: parse reservation commands's action and rtype to string

Parse reservation commands's action(including rrega, racqa and rrela)
and rtype to string to make the trace log more human-readable.

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>

diff --git a/drivers/nvme/host/trace.c b/drivers/nvme/host/trace.c
index 87c437fc070d12632bdec27f912d1f16fd6f7e3c..ad25ad1e40412cef5525de3f52cc1c1d3793f8f1 100644 (file)
--- a/drivers/nvme/host/trace.c
+++ b/drivers/nvme/host/trace.c
@@ -228,27 +228,61 @@ static const char *nvme_trace_zone_mgmt_recv(struct trace_seq *p, u8 *cdw10)
 
 static const char *nvme_trace_resv_reg(struct trace_seq *p, u8 *cdw10)
 {
+       static const char * const rrega_strs[] = {
+               [0x00] = "register",
+               [0x01] = "unregister",
+               [0x02] = "replace",
+       };
        const char *ret = trace_seq_buffer_ptr(p);
        u8 rrega = cdw10[0] & 0x7;
        u8 iekey = (cdw10[0] >> 3) & 0x1;
        u8 ptpl = (cdw10[3] >> 6) & 0x3;
+       const char *rrega_str;
+
+       if (rrega < ARRAY_SIZE(rrega_strs) && rrega_strs[rrega])
+               rrega_str = rrega_strs[rrega];
+       else
+               rrega_str = "reserved";
 
-       trace_seq_printf(p, "rrega=%u, iekey=%u, ptpl=%u",
-                        rrega, iekey, ptpl);
+       trace_seq_printf(p, "rrega=%u:%s, iekey=%u, ptpl=%u",
+                        rrega, rrega_str, iekey, ptpl);
        trace_seq_putc(p, 0);
 
        return ret;
 }
 
+static const char * const rtype_strs[] = {
+       [0x00] = "reserved",
+       [0x01] = "write exclusive",
+       [0x02] = "exclusive access",
+       [0x03] = "write exclusive registrants only",
+       [0x04] = "exclusive access registrants only",
+       [0x05] = "write exclusive all registrants",
+       [0x06] = "exclusive access all registrants",
+};
+
 static const char *nvme_trace_resv_acq(struct trace_seq *p, u8 *cdw10)
 {
+       static const char * const racqa_strs[] = {
+               [0x00] = "acquire",
+               [0x01] = "preempt",
+               [0x02] = "preempt and abort",
+       };
        const char *ret = trace_seq_buffer_ptr(p);
        u8 racqa = cdw10[0] & 0x7;
        u8 iekey = (cdw10[0] >> 3) & 0x1;
        u8 rtype = cdw10[1];
+       const char *racqa_str = "reserved";
+       const char *rtype_str = "reserved";
 
-       trace_seq_printf(p, "racqa=%u, iekey=%u, rtype=%u",
-                        racqa, iekey, rtype);
+       if (racqa < ARRAY_SIZE(racqa_strs) && racqa_strs[racqa])
+               racqa_str = racqa_strs[racqa];
+
+       if (rtype < ARRAY_SIZE(rtype_strs) && rtype_strs[rtype])
+               rtype_str = rtype_strs[rtype];
+
+       trace_seq_printf(p, "racqa=%u:%s, iekey=%u, rtype=%u:%s",
+                        racqa, racqa_str, iekey, rtype, rtype_str);
        trace_seq_putc(p, 0);
 
        return ret;
@@ -256,13 +290,25 @@ static const char *nvme_trace_resv_acq(struct trace_seq *p, u8 *cdw10)
 
 static const char *nvme_trace_resv_rel(struct trace_seq *p, u8 *cdw10)
 {
+       static const char * const rrela_strs[] = {
+               [0x00] = "release",
+               [0x01] = "clear",
+       };
        const char *ret = trace_seq_buffer_ptr(p);
        u8 rrela = cdw10[0] & 0x7;
        u8 iekey = (cdw10[0] >> 3) & 0x1;
        u8 rtype = cdw10[1];
+       const char *rrela_str = "reserved";
+       const char *rtype_str = "reserved";
+
+       if (rrela < ARRAY_SIZE(rrela_strs) && rrela_strs[rrela])
+               rrela_str = rrela_strs[rrela];
+
+       if (rtype < ARRAY_SIZE(rtype_strs) && rtype_strs[rtype])
+               rtype_str = rtype_strs[rtype];
 
-       trace_seq_printf(p, "rrela=%u, iekey=%u, rtype=%u",
-                        rrela, iekey, rtype);
+       trace_seq_printf(p, "rrela=%u:%s, iekey=%u, rtype=%u:%s",
+                        rrela, rrela_str, iekey, rtype, rtype_str);
        trace_seq_putc(p, 0);
 
        return ret;