]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
accel/habanalabs: fix bug of not fetching addr_dec info
authorOfir Bitton <obitton@habana.ai>
Wed, 17 May 2023 17:47:44 +0000 (20:47 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Thu, 8 Jun 2023 09:35:56 +0000 (12:35 +0300)
addr_dec info should always be fetched, regardless of cause value.

Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index 1cb2b72e1cd2152259f4b19b7363f5961520a134..0d41adf4792cd6395acd7bee33a7f5671e96cda9 100644 (file)
@@ -8769,6 +8769,9 @@ static int gaudi2_print_pcie_addr_dec_info(struct hl_device *hdev, u16 event_typ
        u32 error_count = 0;
        int i;
 
+       gaudi2_print_event(hdev, event_type, true,
+               "intr_cause_data: %#llx", intr_cause_data);
+
        for (i = 0 ; i < GAUDI2_NUM_OF_PCIE_ADDR_DEC_ERR_CAUSE ; i++) {
                if (!(intr_cause_data & BIT_ULL(i)))
                        continue;
@@ -8781,10 +8784,11 @@ static int gaudi2_print_pcie_addr_dec_info(struct hl_device *hdev, u16 event_typ
                 * Always check for LBW and HBW additional info as the indication itself is
                 * sometimes missing
                 */
-               hl_check_for_glbl_errors(hdev);
-               gaudi2_print_pcie_mstr_rr_mstr_if_razwi_info(hdev, event_mask);
        }
 
+       hl_check_for_glbl_errors(hdev);
+       gaudi2_print_pcie_mstr_rr_mstr_if_razwi_info(hdev, event_mask);
+
        return error_count;
 }