]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
gpio: sim: use device_match_name() instead of strcmp(dev_name(...
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Jun 2024 14:05:46 +0000 (16:05 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 11 Jun 2024 19:38:41 +0000 (21:38 +0200)
Use the dedicated helper for comparing device names against strings.
While at it: reshuffle the code a bit for less indentation.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240610140548.35358-2-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-sim.c

index 2ed5cbe7c8a8ad9c26767c78effdee59ac599703..278bb0c546368b24405f313f824f6384839c3b00 100644 (file)
@@ -581,19 +581,19 @@ static int gpio_sim_bus_notifier_call(struct notifier_block *nb,
 
        snprintf(devname, sizeof(devname), "gpio-sim.%u", simdev->id);
 
-       if (strcmp(dev_name(dev), devname) == 0) {
-               if (action == BUS_NOTIFY_BOUND_DRIVER)
-                       simdev->driver_bound = true;
-               else if (action == BUS_NOTIFY_DRIVER_NOT_BOUND)
-                       simdev->driver_bound = false;
-               else
-                       return NOTIFY_DONE;
-
-               complete(&simdev->probe_completion);
-               return NOTIFY_OK;
-       }
+       if (!device_match_name(dev, devname))
+               return NOTIFY_DONE;
+
+       if (action == BUS_NOTIFY_BOUND_DRIVER)
+               simdev->driver_bound = true;
+       else if (action == BUS_NOTIFY_DRIVER_NOT_BOUND)
+               simdev->driver_bound = false;
+       else
+               return NOTIFY_DONE;
+
+       complete(&simdev->probe_completion);
 
-       return NOTIFY_DONE;
+       return NOTIFY_OK;
 }
 
 static struct gpio_sim_device *to_gpio_sim_device(struct config_item *item)