]> www.infradead.org Git - nvme.git/commitdiff
spi: axi-spi-engine: remove platform_set_drvdata()
authorDavid Lechner <dlechner@baylibre.com>
Wed, 26 Jun 2024 19:45:17 +0000 (14:45 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 27 Jun 2024 11:18:03 +0000 (12:18 +0100)
platform_get_drvdata() is never called in the AXI SPI Engine driver, so
platform_set_drvdata() is not needed. Remove it. This also lets us
avoid the final error check in the probe function.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20240626-spi-axi-spi-engine-remove-drvdata-v1-1-1752e372dd5d@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-axi-spi-engine.c

index 3231f67ae2650d73a059533553b5799b6105a049..03588fac9215ce40f238720fc8e2ecfbe6b278d5 100644 (file)
@@ -690,13 +690,7 @@ static int spi_engine_probe(struct platform_device *pdev)
        if (host->max_speed_hz == 0)
                return dev_err_probe(&pdev->dev, -EINVAL, "spi_clk rate is 0");
 
-       ret = devm_spi_register_controller(&pdev->dev, host);
-       if (ret)
-               return ret;
-
-       platform_set_drvdata(pdev, host);
-
-       return 0;
+       return devm_spi_register_controller(&pdev->dev, host);
 }
 
 static const struct of_device_id spi_engine_match_table[] = {