wifi: mwifiex: Use helpers to check multicast addresses

Use is_multicast_ether_addr() and is_unicast_ether_addr()
to check the addresses.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20230814124212.302738-3-ruanjinjie@huawei.com

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 3604abcbcff9326f8b6e653c87012c863eaa74cb..b909a7665e9cc17c21b4c29afd2aabac1f878291 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -3359,7 +3359,7 @@ static int mwifiex_set_wowlan_mef_entry(struct mwifiex_private *priv,
                }
 
                if (!wowlan->patterns[i].pkt_offset) {
-                       if (!(byte_seq[0] & 0x01) &&
+                       if (is_unicast_ether_addr(byte_seq) &&
                            (byte_seq[MWIFIEX_MEF_MAX_BYTESEQ] == 1)) {
                                mef_cfg->criteria |= MWIFIEX_CRITERIA_UNICAST;
                                continue;

diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c b/drivers/net/wireless/marvell/mwifiex/wmm.c
index 00a5679b5c51febf2297633a72ab46a79787663c..8558995e8fc73d7744c68af3547e468ffa7a3d2d 100644 (file)
--- a/drivers/net/wireless/marvell/mwifiex/wmm.c
+++ b/drivers/net/wireless/marvell/mwifiex/wmm.c
@@ -871,7 +871,7 @@ mwifiex_wmm_add_buf_txqueue(struct mwifiex_private *priv,
                }
        } else {
                memcpy(ra, skb->data, ETH_ALEN);
-               if (ra[0] & 0x01 || mwifiex_is_skb_mgmt_frame(skb))
+               if (is_multicast_ether_addr(ra) || mwifiex_is_skb_mgmt_frame(skb))
                        eth_broadcast_addr(ra);
                ra_list = mwifiex_wmm_get_queue_raptr(priv, tid_down, ra);
        }