]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
arm64: dts: rockchip: Fix the headphone detection on the orangepi 5 plus
authorMaud Spierings <maud_spierings@hotmail.com>
Sat, 23 Aug 2025 12:43:50 +0000 (14:43 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 24 Aug 2025 06:14:10 +0000 (08:14 +0200)
The logic of the headphone detect pin seems to be inverted, with this
change headphones actually output sound when plugged in.

Verified by checking /sys/kernel/debug/gpio and by listening.

Fixes: 236d225e1ee7 ("arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5-plus")
Signed-off-by: Maud Spierings <maud_spierings@hotmail.com>
Reviewed-by: Ondřej Jirman <megi@xff.cz>
Link: https://lore.kernel.org/r/20250823-orangepi5-v1-1-ae77dd0e06d7@hotmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts

index 121e4d1c3fa5dab0d08edf7cba692a765b48f7b4..8222f1fae8fadc5cbb4ef16b3db5ed975ed43915 100644 (file)
@@ -77,7 +77,7 @@
        pinctrl-names = "default";
        pinctrl-0 = <&hp_detect>;
        simple-audio-card,aux-devs = <&speaker_amp>, <&headphone_amp>;
-       simple-audio-card,hp-det-gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_LOW>;
+       simple-audio-card,hp-det-gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_HIGH>;
        simple-audio-card,widgets =
                "Microphone", "Onboard Microphone",
                "Microphone", "Microphone Jack",