]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nbft: Include SSNS index in error messages
authorTomas Bzatek <tbzatek@redhat.com>
Thu, 15 Feb 2024 14:37:51 +0000 (09:37 -0500)
committerDaniel Wagner <wagi@monom.org>
Tue, 19 Mar 2024 16:44:03 +0000 (17:44 +0100)
In case of complex NBFT tables, multiple messages printed out
start to get confusing. Better to print SSNS indexes for easier
identification in further debugging.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
nbft.c

diff --git a/nbft.c b/nbft.c
index 50f4e6e5bc50cbe948be56517458b85445d48aba..e24e9eb4d137d48e0be659c2abb197f1777e1fab 100644 (file)
--- a/nbft.c
+++ b/nbft.c
@@ -188,7 +188,8 @@ int discover_from_nbft(nvme_root_t r, char *hostnqn_arg, char *hostid_arg,
                                if (ret == -1 && (*ss)->unavailable) {
                                        if (verbose >= 1)
                                                fprintf(stderr,
-                                                       "subsystem reported as unavailable, skipping\n");
+                                                       "SSNS %d reported as unavailable, skipping\n",
+                                                       (*ss)->index);
                                        continue;
                                }
 
@@ -218,12 +219,14 @@ int discover_from_nbft(nvme_root_t r, char *hostnqn_arg, char *hostid_arg,
                                        ret = nvmf_add_ctrl(h, c, cfg);
                                        if (ret == 0 && verbose >= 1)
                                                fprintf(stderr,
-                                                       "connect with host_traddr=\"%s\" failed, success after omitting host_traddr\n",
+                                                       "SSNS %d: connect with host_traddr=\"%s\" failed, success after omitting host_traddr\n",
+                                                       (*ss)->index,
                                                        host_traddr);
                                }
 
                                if (ret)
-                                       fprintf(stderr, "no controller found\n");
+                                       fprintf(stderr, "SSNS %d: no controller found\n",
+                                               (*ss)->index);
                                else {
                                        if (flags == NORMAL)
                                                print_connect_msg(c);