platform/x86: silicom: use new GPIO line value setter callbacks

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20250408-gpiochip-set-rv-platform-x86-v1-3-6f67e76a722c@linaro.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c
index c0910af16a3ac2719cd330eb6617232411e4f7ed..021f3fed197a69dc10bb8983c7a17986ca2fb69c 100644 (file)
--- a/drivers/platform/x86/silicom-platform.c
+++ b/drivers/platform/x86/silicom-platform.c
@@ -245,18 +245,19 @@ static int silicom_gpio_direction_input(struct gpio_chip *gc,
        return direction == GPIO_LINE_DIRECTION_IN ? 0 : -EINVAL;
 }
 
-static void silicom_gpio_set(struct gpio_chip *gc,
-                            unsigned int offset,
-                            int value)
+static int silicom_gpio_set(struct gpio_chip *gc, unsigned int offset,
+                           int value)
 {
        int direction = silicom_gpio_get_direction(gc, offset);
        u8 *channels = gpiochip_get_data(gc);
        int channel = channels[offset];
 
        if (direction == GPIO_LINE_DIRECTION_IN)
-               return;
+               return -EPERM;
 
        silicom_mec_port_set(channel, !value);
+
+       return 0;
 }
 
 static int silicom_gpio_direction_output(struct gpio_chip *gc,
@@ -469,7 +470,7 @@ static struct gpio_chip silicom_gpio_chip = {
        .direction_input = silicom_gpio_direction_input,
        .direction_output = silicom_gpio_direction_output,
        .get = silicom_gpio_get,
-       .set = silicom_gpio_set,
+       .set_rv = silicom_gpio_set,
        .base = -1,
        .ngpio = ARRAY_SIZE(plat_0222_gpio_channels),
        .names = plat_0222_gpio_names,