]> www.infradead.org Git - users/hch/misc.git/commitdiff
cifs: Allow fallback code in smb_set_file_info() also for directories
authorPali Rohár <pali@kernel.org>
Mon, 30 Dec 2024 20:21:31 +0000 (21:21 +0100)
committerSteve French <stfrench@microsoft.com>
Fri, 10 Oct 2025 04:01:24 +0000 (23:01 -0500)
On NT systems, it is possible to do SMB open call also for directories.
Open argument CREATE_NOT_DIR disallows opening directories. So in fallback
code path in smb_set_file_info() remove CREATE_NOT_DIR restriction to allow
it also for directories.

Similar fallback is implemented also in CIFSSMBSetPathInfoFB() function and
this function already allows to call operation for directories.

Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb1ops.c

index 3fdbb71036cff2f940345a461815c511ad7db989..7b17668e2a54f239e1b41ad8320e09e773530a2b 100644 (file)
@@ -1032,7 +1032,7 @@ smb_set_file_info(struct inode *inode, const char *full_path,
                .tcon = tcon,
                .cifs_sb = cifs_sb,
                .desired_access = SYNCHRONIZE | FILE_WRITE_ATTRIBUTES,
-               .create_options = cifs_create_options(cifs_sb, CREATE_NOT_DIR),
+               .create_options = cifs_create_options(cifs_sb, 0),
                .disposition = FILE_OPEN,
                .path = full_path,
                .fid = &fid,