]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
cpuidle: psci: Drop redundant assignment of CPUIDLE_FLAG_RCU_IDLE
authorUlf Hansson <ulf.hansson@linaro.org>
Mon, 27 May 2024 14:25:55 +0000 (16:25 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 5 Aug 2024 11:24:28 +0000 (13:24 +0200)
When using the hierarchical topology and PSCI OSI-mode we may end up
overriding the deepest idle-state's ->enter|enter_s2idle() callbacks, but
there is no point to also re-assign the CPUIDLE_FLAG_RCU_IDLE for the
idle-state in question, as that has already been set when parsing the
states from DT. See init_state_node().

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com> # qcm6490 with PREEMPT_RT set
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20240527142557.321610-6-ulf.hansson@linaro.org
drivers/cpuidle/cpuidle-psci.c

index 782030a27703116fd0adeff4ce2123d05d60dc1a..d82a8bc1b1949b258918e0a6b4ceae4589790a66 100644 (file)
@@ -234,7 +234,6 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv,
         * of a shared state for the domain, assumes the domain states are all
         * deeper states.
         */
-       drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE;
        drv->states[state_count - 1].enter = psci_enter_domain_idle_state;
        drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state;
        psci_cpuidle_use_cpuhp = true;