]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
powerpc/kvm: Fix ifdef to remove build warning
authorMadhavan Srinivasan <maddy@linux.ibm.com>
Sun, 18 May 2025 04:41:04 +0000 (10:11 +0530)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Wed, 20 Aug 2025 08:33:44 +0000 (14:03 +0530)
When compiling for pseries or powernv defconfig with "make C=1",
these warning were reported bu sparse tool in powerpc/kernel/kvm.c

arch/powerpc/kernel/kvm.c:635:9: warning: switch with no cases
arch/powerpc/kernel/kvm.c:646:9: warning: switch with no cases

Currently #ifdef were added after the switch case which are specific
for BOOKE and PPC_BOOK3S_32. These are not enabled in pseries/powernv
defconfig. Fix it by moving the #ifdef before switch(){}

Fixes: cbe487fac7fc0 ("KVM: PPC: Add mtsrin PV code")
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250518044107.39928-1-maddy@linux.ibm.com
arch/powerpc/kernel/kvm.c

index 5b3c093611baf142b679315fe61c2e2c1459a4ee..7209d00a9c25760e2a5d49297ded70b0f36a482a 100644 (file)
@@ -632,19 +632,19 @@ static void __init kvm_check_ins(u32 *inst, u32 features)
 #endif
        }
 
-       switch (inst_no_rt & ~KVM_MASK_RB) {
 #ifdef CONFIG_PPC_BOOK3S_32
+       switch (inst_no_rt & ~KVM_MASK_RB) {
        case KVM_INST_MTSRIN:
                if (features & KVM_MAGIC_FEAT_SR) {
                        u32 inst_rb = _inst & KVM_MASK_RB;
                        kvm_patch_ins_mtsrin(inst, inst_rt, inst_rb);
                }
                break;
-#endif
        }
+#endif
 
-       switch (_inst) {
 #ifdef CONFIG_BOOKE
+       switch (_inst) {
        case KVM_INST_WRTEEI_0:
                kvm_patch_ins_wrteei_0(inst);
                break;
@@ -652,8 +652,8 @@ static void __init kvm_check_ins(u32 *inst, u32 features)
        case KVM_INST_WRTEEI_1:
                kvm_patch_ins_wrtee(inst, 0, 1);
                break;
-#endif
        }
+#endif
 }
 
 extern u32 kvm_template_start[];