]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: magnetometer: bmc150_magn: Drop most likely fake ACPI IDs
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 18 Oct 2024 14:58:05 +0000 (17:58 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 21 Oct 2024 18:19:24 +0000 (19:19 +0100)
The commits in question do not proove that ACPI IDs exist.
Quite likely it was a cargo cult addition while doing that
for DT-based enumeration. Drop most likely fake ACPI IDs.

The to be removed IDs has been checked against the following resources:
1) DuckDuckGo
2) Google
3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
This gives no useful results in regard to DSDT, moreover, the official
vendor IDs in the registry for Bosh are BSG and BOSC.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patch.msgid.link/20241018145805.2181682-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/magnetometer/bmc150_magn_i2c.c
drivers/iio/magnetometer/bmc150_magn_spi.c

index a28d46d59875faefa588538f8d02faab5d61ecec..17e10a462ac85dc73d0636a71ebc6fb784cc20d4 100644 (file)
@@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client)
        bmc150_magn_remove(&client->dev);
 }
 
-static const struct acpi_device_id bmc150_magn_acpi_match[] = {
-       {"BMC150B", 0},
-       {"BMC156B", 0},
-       {"BMM150B", 0},
-       {},
-};
-MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match);
-
 static const struct i2c_device_id bmc150_magn_i2c_id[] = {
        { "bmc150_magn" },
        { "bmc156_magn" },
@@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = {
        .driver = {
                .name   = "bmc150_magn_i2c",
                .of_match_table = bmc150_magn_of_match,
-               .acpi_match_table = bmc150_magn_acpi_match,
                .pm     = &bmc150_magn_pm_ops,
        },
        .probe          = bmc150_magn_i2c_probe,
index abc75a05c46afdf2d49ec1324aebbf37207f405a..c850de1bc79b0d4cbda5a520809f516af5ea8348 100644 (file)
@@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = {
 };
 MODULE_DEVICE_TABLE(spi, bmc150_magn_spi_id);
 
-static const struct acpi_device_id bmc150_magn_acpi_match[] = {
-       {"BMC150B", 0},
-       {"BMC156B", 0},
-       {"BMM150B", 0},
-       {},
-};
-MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match);
-
 static struct spi_driver bmc150_magn_spi_driver = {
        .probe          = bmc150_magn_spi_probe,
        .remove         = bmc150_magn_spi_remove,
        .id_table       = bmc150_magn_spi_id,
        .driver = {
-               .acpi_match_table = bmc150_magn_acpi_match,
                .name   = "bmc150_magn_spi",
        },
 };