]> www.infradead.org Git - users/hch/misc.git/commitdiff
PCI: plda: Remove dev_err_probe() when the errno is -ENOMEM
authorXichao Zhao <zhao.xichao@vivo.com>
Wed, 20 Aug 2025 08:52:00 +0000 (16:52 +0800)
committerManivannan Sadhasivam <mani@kernel.org>
Mon, 8 Sep 2025 10:14:31 +0000 (15:44 +0530)
The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
Therefore, remove the useless call to dev_err_probe(), and just
return the value instead.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
[mani: reworded the subject]
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
drivers/pci/controller/plda/pcie-plda-host.c

index 8e2db2e5b64b96af138454a213f33c588a3b1368..3c2f683830107b9c40ac633a51923a0956ba7a19 100644 (file)
@@ -599,8 +599,7 @@ int plda_pcie_host_init(struct plda_pcie_rp *port, struct pci_ops *ops,
 
        bridge = devm_pci_alloc_host_bridge(dev, 0);
        if (!bridge)
-               return dev_err_probe(dev, -ENOMEM,
-                                    "failed to alloc bridge\n");
+               return -ENOMEM;
 
        if (port->host_ops && port->host_ops->host_init) {
                ret = port->host_ops->host_init(port);