]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: update nvme_insert_tls_key_versioned() return handling
authorMartin George <marting@netapp.com>
Sun, 1 Sep 2024 11:51:47 +0000 (17:21 +0530)
committerDaniel Wagner <wagi@monom.org>
Mon, 9 Sep 2024 07:10:50 +0000 (09:10 +0200)
Treat nvme_insert_tls_key_versioned() return value of zero as
errors too.

Signed-off-by: Martin George <marting@netapp.com>
nvme.c

diff --git a/nvme.c b/nvme.c
index a69ac9cdf5f863503213bbbf5bd2f5a817278f40..900b1c0e190509e3fc84f3b94567a337f9fef6f2 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -9276,7 +9276,7 @@ static int gen_tls_key(int argc, char **argv, struct command *command, struct pl
                                        cfg.keytype, cfg.hostnqn,
                                        cfg.subsysnqn, cfg.identity,
                                        cfg.hmac, raw_secret, key_len);
-               if (tls_key < 0) {
+               if (tls_key <= 0) {
                        nvme_show_error("Failed to insert key, error %d", errno);
                        return -errno;
                }
@@ -9369,7 +9369,7 @@ static int check_tls_key(int argc, char **argv, struct command *command, struct
                                        cfg.keytype, cfg.hostnqn,
                                        cfg.subsysnqn, cfg.identity,
                                        hmac, decoded_key, decoded_len);
-               if (tls_key < 0) {
+               if (tls_key <= 0) {
                        nvme_show_error("Failed to insert key, error %d", errno);
                        return -errno;
                }