]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
EDAC: skx_common: get rid of unused type var
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 13 Sep 2019 14:23:08 +0000 (11:23 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:26:52 +0000 (11:26 +0200)
[ Upstream commit f05390d30e20cccd8f8de981dee42bcdd8d2d137 ]

drivers/edac/skx_common.c: In function ‘skx_mce_output_error’:
drivers/edac/skx_common.c:478:8: warning: variable ‘type’ set but not used [-Wunused-but-set-variable]
  478 |  char *type, *optype;
      |        ^~~~

Acked-by: Borislav Petkov <bp@alien8.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/edac/skx_common.c

index 2177ad765bd1696070409b092766cf7fb465b6f5..4ca87723dcdcd6b1867ace219ab1b7005b2f7474 100644 (file)
@@ -475,7 +475,7 @@ static void skx_mce_output_error(struct mem_ctl_info *mci,
                                 struct decoded_addr *res)
 {
        enum hw_event_mc_err_type tp_event;
-       char *type, *optype;
+       char *optype;
        bool ripv = GET_BITFIELD(m->mcgstatus, 0, 0);
        bool overflow = GET_BITFIELD(m->status, 62, 62);
        bool uncorrected_error = GET_BITFIELD(m->status, 61, 61);
@@ -490,14 +490,11 @@ static void skx_mce_output_error(struct mem_ctl_info *mci,
        if (uncorrected_error) {
                core_err_cnt = 1;
                if (ripv) {
-                       type = "FATAL";
                        tp_event = HW_EVENT_ERR_FATAL;
                } else {
-                       type = "NON_FATAL";
                        tp_event = HW_EVENT_ERR_UNCORRECTED;
                }
        } else {
-               type = "CORRECTED";
                tp_event = HW_EVENT_ERR_CORRECTED;
        }