]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
powerpc/boot/install.sh: Fix shellcheck warnings
authorMadhavan Srinivasan <maddy@linux.ibm.com>
Sun, 18 May 2025 04:41:07 +0000 (10:11 +0530)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Wed, 20 Aug 2025 08:35:18 +0000 (14:05 +0530)
Fix shellcheck warning such as
"Double quote to prevent globbing and word splitting." and
Use $(...) notation instead of legacy backticks `...`.

Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250518044107.39928-4-maddy@linux.ibm.com
arch/powerpc/boot/install.sh

index 101fcb397a0fe6a1faa099d91cb7e8ca3e9315f5..c3df6c27ce754fd4b83d8b52db164c0a7cc7c90a 100755 (executable)
 set -e
 
 # this should work for both the pSeries zImage and the iSeries vmlinux.sm
-image_name=`basename $2`
+image_name=$(basename "$2")
 
 
 echo "Warning: '${INSTALLKERNEL}' command not available... Copying" \
      "directly to $4/$image_name-$1" >&2
 
-if [ -f $4/$image_name-$1 ]; then
-       mv $4/$image_name-$1 $4/$image_name-$1.old
+if [ -f "$4"/"$image_name"-"$1" ]; then
+       mv "$4"/"$image_name"-"$1" "$4"/"$image_name"-"$1".old
 fi
 
-if [ -f $4/System.map-$1 ]; then
-       mv $4/System.map-$1 $4/System-$1.old
+if [ -f "$4"/System.map-"$1" ]; then
+       mv "$4"/System.map-"$1" "$4"/System-"$1".old
 fi
 
-cat $2 > $4/$image_name-$1
-cp $3 $4/System.map-$1
+cat "$2" > "$4"/"$image_name"-"$1"
+cp "$3" "$4"/System.map-"$1"