]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
be2net: signedness bug in be_msix_enable()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 29 Jun 2016 14:39:43 +0000 (17:39 +0300)
committerDhaval Giani <dhaval.giani@oracle.com>
Wed, 8 Mar 2017 01:05:24 +0000 (20:05 -0500)
Orabug: 25570957

"num_vec" needs to be signed for the error handling to work.

Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sathya Perla <sathya.perla@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 6fde0e63eccbaf21fa278b240b8129fec14b864b)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/net/ethernet/emulex/benet/be_main.c

index 5db35dc9f8fb2f798e481447decc0bb15645c480..bb3cf48e3c552cca10453507245386ec0a9e1637 100644 (file)
@@ -3249,8 +3249,9 @@ static void be_msix_disable(struct be_adapter *adapter)
 
 static int be_msix_enable(struct be_adapter *adapter)
 {
-       int i, num_vec;
+       unsigned int i, max_roce_eqs;
        struct device *dev = &adapter->pdev->dev;
+       int num_vec;
 
        /* If RoCE is supported, program the max number of vectors that
         * could be used for NIC and RoCE, else, just program the number