]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
fm10k: don't use BIT() macro where the value isn't a bitmask
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 14 Apr 2016 20:17:27 +0000 (13:17 -0700)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 26 Feb 2017 06:04:12 +0000 (22:04 -0800)
The FM10K_MAX_DATA_PER_TXD is really just using a bitshift as a power of
2 operation in an efficient manner. We shouldn't represent this as a BIT()
because that obscures the intention of the operation.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Orabug: 25394529
(cherry picked from commit 124579de462e6c232c4c321c3ec1ed81964cf78b)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/ethernet/intel/fm10k/fm10k.h

index db3ec579701df800bcb8b823d56ee5cce1b28c84..8f4d5172640bfea98de56b7d3b4f9cbb15cc550c 100644 (file)
@@ -423,7 +423,7 @@ static inline u16 fm10k_desc_unused(struct fm10k_ring *ring)
         (&(((union fm10k_rx_desc *)((R)->desc))[i]))
 
 #define FM10K_MAX_TXD_PWR      14
-#define FM10K_MAX_DATA_PER_TXD BIT(FM10K_MAX_TXD_PWR)
+#define FM10K_MAX_DATA_PER_TXD (1u << FM10K_MAX_TXD_PWR)
 
 /* Tx Descriptors needed, worst case */
 #define TXD_USE_COUNT(S)       DIV_ROUND_UP((S), FM10K_MAX_DATA_PER_TXD)