]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
serial: Fix potential null-ptr-deref in mlb_usio_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Thu, 3 Apr 2025 07:03:39 +0000 (15:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Apr 2025 14:53:34 +0000 (16:53 +0200)
devm_ioremap() can return NULL on error. Currently, mlb_usio_probe()
does not check for this case, which could result in a NULL pointer
dereference.

Add NULL check after devm_ioremap() to prevent this issue.

Fixes: ba44dc043004 ("serial: Add Milbeaut serial control")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Link: https://lore.kernel.org/r/20250403070339.64990-1-bsdhenrymartin@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/milbeaut_usio.c

index 059bea18dbab569a610cb96a1f153a01ca9d362c..4e47dca2c4ed9ce650a21f8345aa445178a1c6ee 100644 (file)
@@ -523,7 +523,10 @@ static int mlb_usio_probe(struct platform_device *pdev)
        }
        port->membase = devm_ioremap(&pdev->dev, res->start,
                                resource_size(res));
-
+       if (!port->membase) {
+               ret = -ENOMEM;
+               goto failed;
+       }
        ret = platform_get_irq_byname(pdev, "rx");
        mlb_usio_irq[index][RX] = ret;