]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: stmmac: remove priv->tx_lpi_enabled
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 8 Jan 2025 16:48:09 +0000 (16:48 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 Jan 2025 01:51:01 +0000 (17:51 -0800)
Through using phylib's EEE state, priv->tx_lpi_enabled has become a
write-only variable. Remove it.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tVZE1-0002KS-K1@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index b50f48e17f4c45158f3780988694004fae86c359..d94fdecc8f3bc70c31048c9a2596f2c673ef4274 100644 (file)
@@ -308,7 +308,6 @@ struct stmmac_priv {
        int eee_enabled;
        int eee_active;
        u32 tx_lpi_timer;
-       int tx_lpi_enabled;
        int eee_tw_timer;
        bool eee_sw_timer_en;
        unsigned int mode;
index e58a638de6233b3815f1e5a2ba979f684de5efbb..360d67ba648394a370685addec03c81841b7c7e0 100644 (file)
@@ -968,7 +968,6 @@ static void stmmac_mac_link_down(struct phylink_config *config,
 
        stmmac_mac_set(priv, priv->ioaddr, false);
        priv->eee_active = false;
-       priv->tx_lpi_enabled = false;
        priv->eee_enabled = stmmac_eee_init(priv);
        stmmac_set_eee_pls(priv, priv->hw, false);
 
@@ -1083,7 +1082,6 @@ static void stmmac_mac_link_up(struct phylink_config *config,
                                STMMAC_FLAG_RX_CLK_RUNS_IN_LPI)) >= 0;
                priv->tx_lpi_timer = phy->eee_cfg.tx_lpi_timer;
                priv->eee_enabled = stmmac_eee_init(priv);
-               priv->tx_lpi_enabled = priv->eee_enabled;
                stmmac_set_eee_pls(priv, priv->hw, true);
        }