hwmon: (iio_hwmon) Do not duplicate or sanitize fixed string

Calling devm_kstrdup() on a fixed string is unnecessary, as is validating
its contents. Rearrange the code to avoid both.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c
index 7566991f1c04798b75e30389ac202a8917a1df6f..eed66e533ee29c59389f00082dbd69bf1ca7cb65 100644 (file)
--- a/drivers/hwmon/iio_hwmon.c
+++ b/drivers/hwmon/iio_hwmon.c
@@ -137,14 +137,15 @@ static int iio_hwmon_probe(struct platform_device *pdev)
        st->attr_group.attrs = st->attrs;
        st->groups[0] = &st->attr_group;
 
-       if (dev->of_node)
+       if (dev->of_node) {
                sname = devm_kasprintf(dev, GFP_KERNEL, "%pOFn", dev->of_node);
-       else
-               sname = devm_kstrdup(dev, "iio_hwmon", GFP_KERNEL);
-       if (!sname)
-               return -ENOMEM;
+               if (!sname)
+                       return -ENOMEM;
+               strreplace(sname, '-', '_');
+       } else {
+               sname = "iio_hwmon";
+       }
 
-       strreplace(sname, '-', '_');
        hwmon_dev = devm_hwmon_device_register_with_groups(dev, sname, st,
                                                           st->groups);
        return PTR_ERR_OR_ZERO(hwmon_dev);