drm/amdgpu/powerplay: properly set PP_GFXOFF_MASK (v2)

So that the setting reflects what the hw supports. This will
be used in a subsequent patch so needs to be correct.

v2: squash in fix from Colin Ian King

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205497
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 223c5a794561050c0971f981b5fb1c9e170661e5..b73561957d24b1fa6d6f4b8176f14955f12a5d07 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -730,6 +730,7 @@ static int smu_set_funcs(struct amdgpu_device *adev)
 
        switch (adev->asic_type) {
        case CHIP_VEGA20:
+               adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                vega20_set_ppt_funcs(smu);
                break;
        case CHIP_NAVI10:
@@ -738,6 +739,7 @@ static int smu_set_funcs(struct amdgpu_device *adev)
                navi10_set_ppt_funcs(smu);
                break;
        case CHIP_ARCTURUS:
+               adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                arcturus_set_ppt_funcs(smu);
                /* OD is not supported on Arcturus */
                smu->od_enabled =false;

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
index a24beaa4fb01819aab14f7e3e3e93972d76284bf..d2909c91d65bf018766f774da2aaa793488da233 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
@@ -81,6 +81,8 @@ static void hwmgr_init_workload_prority(struct pp_hwmgr *hwmgr)
 
 int hwmgr_early_init(struct pp_hwmgr *hwmgr)
 {
+       struct amdgpu_device *adev;
+
        if (!hwmgr)
                return -EINVAL;
 
@@ -94,8 +96,11 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
        hwmgr_init_workload_prority(hwmgr);
        hwmgr->gfxoff_state_changed_by_workload = false;
 
+       adev = hwmgr->adev;
+
        switch (hwmgr->chip_family) {
        case AMDGPU_FAMILY_CI:
+               adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                hwmgr->smumgr_funcs = &ci_smu_funcs;
                ci_set_asic_special_caps(hwmgr);
                hwmgr->feature_mask &= ~(PP_VBI_TIME_SUPPORT_MASK |
@@ -106,12 +111,14 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
                smu7_init_function_pointers(hwmgr);
                break;
        case AMDGPU_FAMILY_CZ:
+               adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                hwmgr->od_enabled = false;
                hwmgr->smumgr_funcs = &smu8_smu_funcs;
                hwmgr->feature_mask &= ~PP_GFXOFF_MASK;
                smu8_init_function_pointers(hwmgr);
                break;
        case AMDGPU_FAMILY_VI:
+               adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                hwmgr->feature_mask &= ~PP_GFXOFF_MASK;
                switch (hwmgr->chip_id) {
                case CHIP_TOPAZ:
@@ -153,6 +160,7 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
        case AMDGPU_FAMILY_AI:
                switch (hwmgr->chip_id) {
                case CHIP_VEGA10:
+                       adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                        hwmgr->feature_mask &= ~PP_GFXOFF_MASK;
                        hwmgr->smumgr_funcs = &vega10_smu_funcs;
                        vega10_hwmgr_init(hwmgr);
@@ -162,6 +170,7 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
                        vega12_hwmgr_init(hwmgr);
                        break;
                case CHIP_VEGA20:
+                       adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
                        hwmgr->feature_mask &= ~PP_GFXOFF_MASK;
                        hwmgr->smumgr_funcs = &vega20_smu_funcs;
                        vega20_hwmgr_init(hwmgr);