]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: i2c: ov5648: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:22 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:25 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov5648.c

index 4b86d2631bd1cd19e6d5c9b8b3d0a1f9c48aeab7..8a3190bf73daf32f5c8bbe0dae6bf71a373f07e7 100644 (file)
@@ -2521,10 +2521,10 @@ static int ov5648_probe(struct i2c_client *client)
 
        /* External Clock */
 
-       sensor->xvclk = devm_clk_get(dev, NULL);
+       sensor->xvclk = devm_v4l2_sensor_clk_get(dev, NULL);
        if (IS_ERR(sensor->xvclk)) {
-               dev_err(dev, "failed to get external clock\n");
-               ret = PTR_ERR(sensor->xvclk);
+               ret = dev_err_probe(dev, PTR_ERR(sensor->xvclk),
+                                   "failed to get external clock\n");
                goto error_endpoint;
        }