]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
hwmon: (vexpress) Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:51 +0000 (13:12 -0600)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 27 Aug 2024 15:10:11 +0000 (08:10 -0700)
Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20240731191312.1710417-13-robh@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/vexpress-hwmon.c

index d82a3b454d0ed3c14cf67f392e42443cc35f4b36..a2e350f52a9e9bd7fb0faf69359532447f41f4e5 100644 (file)
@@ -72,7 +72,7 @@ static umode_t vexpress_hwmon_attr_is_visible(struct kobject *kobj,
                                struct device_attribute, attr);
 
        if (dev_attr->show == vexpress_hwmon_label_show &&
-                       !of_get_property(dev->of_node, "label", NULL))
+                       !of_property_present(dev->of_node, "label"))
                return 0;
 
        return attr->mode;