]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
gpio: mockup: fix resource leak in error path
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Tue, 8 Sep 2020 13:07:49 +0000 (15:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Nov 2020 09:00:24 +0000 (10:00 +0100)
commit 1b02d9e770cd7087f34c743f85ccf5ea8372b047 upstream

If the module init function fails after creating the debugs directory,
it's never removed. Add proper cleanup calls to avoid this resource
leak.

Fixes: 9202ba2397d1 ("gpio: mockup: implement event injecting over debugfs")
Cc: <stable@vger.kernel.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[sudip: adjust context]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpio-mockup.c

index d99c8d8da9a050518b6d05dc3f9f3fff1c1eda8f..a09a1334afbf3e2ba2ca321162fe2e49c0e07465 100644 (file)
@@ -350,6 +350,7 @@ static int __init mock_device_init(void)
        err = platform_driver_register(&gpio_mockup_driver);
        if (err) {
                platform_device_unregister(pdev);
+               debugfs_remove_recursive(gpio_mockup_dbg_dir);
                return err;
        }