]> www.infradead.org Git - users/willy/xarray.git/commitdiff
power: supply: ds2782: Use devm_power_supply_register() helper
authorAndrew Davis <afd@ti.com>
Mon, 2 Dec 2024 21:15:18 +0000 (15:15 -0600)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 4 Dec 2024 21:31:31 +0000 (22:31 +0100)
Use the device lifecycle managed register function. This helps prevent
mistakes like unregistering out of order in cleanup functions and
forgetting to unregister on error paths.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20241202211519.199635-4-afd@ti.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ds2782_battery.c

index a72d8c26650d70a6cb6a15c73fe2456e5b0d1453..ea687b970331497ce864e97192e677fd485284d0 100644 (file)
@@ -314,7 +314,6 @@ static void ds278x_battery_remove(struct i2c_client *client)
 {
        struct ds278x_info *info = i2c_get_clientdata(client);
 
-       power_supply_unregister(info->battery);
        cancel_delayed_work_sync(&info->bat_work);
 }
 
@@ -415,8 +414,9 @@ static int ds278x_battery_probe(struct i2c_client *client)
 
        INIT_DELAYED_WORK(&info->bat_work, ds278x_bat_work);
 
-       info->battery = power_supply_register(&client->dev,
-                                             &info->battery_desc, &psy_cfg);
+       info->battery = devm_power_supply_register(&client->dev,
+                                                  &info->battery_desc,
+                                                  &psy_cfg);
        if (IS_ERR(info->battery)) {
                dev_err(&client->dev, "failed to register battery\n");
                return PTR_ERR(info->battery);