]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/amdgpu: limit single process inside MES
authorShaoyun Liu <shaoyun.liu@amd.com>
Wed, 23 Oct 2024 15:12:00 +0000 (11:12 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 12 Nov 2024 22:02:04 +0000 (17:02 -0500)
This is for MES to limit only one process for the user queues

Signed-off-by: Shaoyun Liu <shaoyun.liu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
drivers/gpu/drm/amd/amdgpu/mes_v12_0.c

index 76093793839e8bd866fd35aa1fab0544e0259550..f57cc72c43cf4b1254a19085cbef507b6db8315f 100644 (file)
@@ -1598,9 +1598,11 @@ static ssize_t amdgpu_gfx_set_enforce_isolation(struct device *dev,
                if (adev->enforce_isolation[i] && !partition_values[i]) {
                        /* Going from enabled to disabled */
                        amdgpu_vmid_free_reserved(adev, AMDGPU_GFXHUB(i));
+                       amdgpu_mes_set_enforce_isolation(adev, i, false);
                } else if (!adev->enforce_isolation[i] && partition_values[i]) {
                        /* Going from disabled to enabled */
                        amdgpu_vmid_alloc_reserved(adev, AMDGPU_GFXHUB(i));
+                       amdgpu_mes_set_enforce_isolation(adev, i, true);
                }
                adev->enforce_isolation[i] = partition_values[i];
        }
index c9ec5c6cad2e2f5856fda68d9e3d1d51ba034164..59ec20b07a6af32f336f84856d437254577b9a72 100644 (file)
@@ -1678,6 +1678,29 @@ bool amdgpu_mes_suspend_resume_all_supported(struct amdgpu_device *adev)
        return is_supported;
 }
 
+/* Fix me -- node_id is used to identify the correct MES instances in the future */
+int amdgpu_mes_set_enforce_isolation(struct amdgpu_device *adev, uint32_t node_id, bool enable)
+{
+       struct mes_misc_op_input op_input = {0};
+       int r;
+
+       op_input.op = MES_MISC_OP_CHANGE_CONFIG;
+       op_input.change_config.option.limit_single_process = enable ? 1 : 0;
+
+       if (!adev->mes.funcs->misc_op) {
+               dev_err(adev->dev, "mes change config is not supported!\n");
+               r = -EINVAL;
+               goto error;
+       }
+
+       r = adev->mes.funcs->misc_op(&adev->mes, &op_input);
+       if (r)
+               dev_err(adev->dev, "failed to change_config.\n");
+
+error:
+       return r;
+}
+
 #if defined(CONFIG_DEBUG_FS)
 
 static int amdgpu_debugfs_mes_event_log_show(struct seq_file *m, void *unused)
index 0666ba91be151b5d77898baceb1ef094ce1de3fa..c6f93cbd6739f064ab70a434b754b8a09d85ef2c 100644 (file)
@@ -309,6 +309,7 @@ enum mes_misc_opcode {
        MES_MISC_OP_WRM_REG_WAIT,
        MES_MISC_OP_WRM_REG_WR_WAIT,
        MES_MISC_OP_SET_SHADER_DEBUGGER,
+       MES_MISC_OP_CHANGE_CONFIG,
 };
 
 struct mes_misc_op_input {
@@ -347,6 +348,21 @@ struct mes_misc_op_input {
                        uint32_t tcp_watch_cntl[4];
                        uint32_t trap_en;
                } set_shader_debugger;
+
+               struct {
+                       union {
+                               struct {
+                                       uint32_t limit_single_process : 1;
+                                       uint32_t enable_hws_logging_buffer : 1;
+                                       uint32_t reserved : 30;
+                               };
+                               uint32_t all;
+                       } option;
+                       struct {
+                               uint32_t tdr_level;
+                               uint32_t tdr_delay;
+                       } tdr_config;
+               } change_config;
        };
 };
 
@@ -517,4 +533,7 @@ static inline void amdgpu_mes_unlock(struct amdgpu_mes *mes)
 }
 
 bool amdgpu_mes_suspend_resume_all_supported(struct amdgpu_device *adev);
+
+int amdgpu_mes_set_enforce_isolation(struct amdgpu_device *adev, uint32_t node_id, bool enable);
+
 #endif /* __AMDGPU_MES_H__ */
index 6f613349694484a94567046d46f6c25bdb325729..9c905b9e937637442570ec20321bdfe2ea93601a 100644 (file)
@@ -644,6 +644,18 @@ static int mes_v11_0_misc_op(struct amdgpu_mes *mes,
                                sizeof(misc_pkt.set_shader_debugger.tcp_watch_cntl));
                misc_pkt.set_shader_debugger.trap_en = input->set_shader_debugger.trap_en;
                break;
+       case MES_MISC_OP_CHANGE_CONFIG:
+               if ((mes->adev->mes.sched_version & AMDGPU_MES_VERSION_MASK) < 0x63) {
+                       dev_err(mes->adev->dev, "MES FW versoin must be larger than 0x63 to support limit single process feature.\n");
+                       return -EINVAL;
+               }
+               misc_pkt.opcode = MESAPI_MISC__CHANGE_CONFIG;
+               misc_pkt.change_config.opcode =
+                               MESAPI_MISC__CHANGE_CONFIG_OPTION_LIMIT_SINGLE_PROCESS;
+               misc_pkt.change_config.option.bits.limit_single_process =
+                               input->change_config.option.limit_single_process;
+               break;
+
        default:
                DRM_ERROR("unsupported misc op (%d) \n", input->op);
                return -EINVAL;
@@ -708,6 +720,9 @@ static int mes_v11_0_set_hw_resources(struct amdgpu_mes *mes)
                                        mes->event_log_gpu_addr;
        }
 
+       if (enforce_isolation)
+               mes_set_hw_res_pkt.limit_single_process = 1;
+
        return mes_v11_0_submit_pkt_and_poll_completion(mes,
                        &mes_set_hw_res_pkt, sizeof(mes_set_hw_res_pkt),
                        offsetof(union MESAPI_SET_HW_RESOURCES, api_status));
index 0c401a5e2fb88caabfd196f156f1f1d25225d085..9ecc5d61e49ba3151cb63c82130f6462a6dbb3c6 100644 (file)
@@ -531,6 +531,14 @@ static int mes_v12_0_misc_op(struct amdgpu_mes *mes,
                                sizeof(misc_pkt.set_shader_debugger.tcp_watch_cntl));
                misc_pkt.set_shader_debugger.trap_en = input->set_shader_debugger.trap_en;
                break;
+       case MES_MISC_OP_CHANGE_CONFIG:
+               misc_pkt.opcode = MESAPI_MISC__CHANGE_CONFIG;
+               misc_pkt.change_config.opcode =
+                               MESAPI_MISC__CHANGE_CONFIG_OPTION_LIMIT_SINGLE_PROCESS;
+               misc_pkt.change_config.option.bits.limit_single_process =
+                               input->change_config.option.limit_single_process;
+               break;
+
        default:
                DRM_ERROR("unsupported misc op (%d) \n", input->op);
                return -EINVAL;
@@ -624,6 +632,9 @@ static int mes_v12_0_set_hw_resources(struct amdgpu_mes *mes, int pipe)
                mes_set_hw_res_pkt.event_intr_history_gpu_mc_ptr = mes->event_log_gpu_addr + pipe * AMDGPU_MES_LOG_BUFFER_SIZE;
        }
 
+       if (enforce_isolation)
+               mes_set_hw_res_pkt.limit_single_process = 1;
+
        return mes_v12_0_submit_pkt_and_poll_completion(mes, pipe,
                        &mes_set_hw_res_pkt, sizeof(mes_set_hw_res_pkt),
                        offsetof(union MESAPI_SET_HW_RESOURCES, api_status));