Fix resource leaks identified by Coverity Scan

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/library.c b/library.c
index 6fbe2d104bbda3aa3990a5f3b4756326a395827f..9e034fd706348a16c8c4276b41d514558ad52177 100644 (file)
--- a/library.c
+++ b/library.c
@@ -115,8 +115,15 @@ struct openconnect_info *openconnect_vpninfo_new(const char *useragent,
        return vpninfo;
 
 err:
-       free(vpninfo->localname);
+       free(vpninfo->platname);
        free(vpninfo->useragent);
+       free(vpninfo->localname);
+#ifdef HAVE_ICONV
+       if (vpninfo->ic_legacy_to_utf8 != (iconv_t)-1)
+               iconv_close(vpninfo->ic_legacy_to_utf8);
+       if (vpninfo->ic_utf8_to_legacy != (iconv_t)-1)
+               iconv_close(vpninfo->ic_legacy_to_utf8);
+#endif
        free(vpninfo);
        return NULL;
 }