util: fix a file handle leak in nvme_uuid_random()

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

diff --git a/src/nvme/util.c b/src/nvme/util.c
index c61dbe9214ba82ef960fba5534e160e337c14708..e8caa5087e1e8a499ba38ba00599a782d24df2c9 100644 (file)
--- a/src/nvme/util.c
+++ b/src/nvme/util.c
@@ -871,13 +871,11 @@ int nvme_uuid_random(unsigned char uuid[NVME_UUID_LEN])
        if (f < 0)
                return -errno;
        n = read(f, uuid, NVME_UUID_LEN);
-       if (n < 0) {
-               close(f);
+       close(f);
+       if (n < 0)
                return -errno;
-       } else if (n != NVME_UUID_LEN) {
-               close(f);
+       else if (n != NVME_UUID_LEN)
                return -EIO;
-       }
 
        /*
         * See https://www.rfc-editor.org/rfc/rfc4122#section-4.4