phy: rockchip-pcie: Simplify error handling with dev_err_probe()

Use the dev_err_probe() helper to simplify error handling during probe.
This also handle scenario, when -EDEFER is returned and useless error
is printed.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Link: https://lore.kernel.org/r/20241012071919.3726-2-linux.amoon@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
index 51cc5ece0e63724d1ce6f9d3ece2f378a28786f0..51e636a1ce33b3d1d55bf3288db4c84f3647f813 100644 (file)
--- a/drivers/phy/rockchip/phy-rockchip-pcie.c
+++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
@@ -371,12 +371,9 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
        mutex_init(&rk_phy->pcie_mutex);
 
        rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
-       if (IS_ERR(rk_phy->phy_rst)) {
-               if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
-                       dev_err(dev,
-                               "missing phy property for reset controller\n");
-               return PTR_ERR(rk_phy->phy_rst);
-       }
+       if (IS_ERR(rk_phy->phy_rst))
+               return dev_err_probe(&pdev->dev, PTR_ERR(rk_phy->phy_rst),
+                                    "missing phy property for reset controller\n");
 
        rk_phy->clk_pciephy_ref = devm_clk_get(dev, "refclk");
        if (IS_ERR(rk_phy->clk_pciephy_ref)) {