fabrics: ignore hostnqn file if its empty

If we read an empty string from /etc/nvme/hostnqn we should
ignore it instead of passing an empty string to the
driver resulting in the error:

nvme_fabrics: unknown parameter or missing value 'hostnqn=' in ctrl creation request

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>

diff --git a/fabrics.c b/fabrics.c
index 57625cd379112048294aa50ad4bd0f27a564852a..98a42783079754fe0342db6ea0954e368e567e80 100644 (file)
--- a/fabrics.c
+++ b/fabrics.c
@@ -672,7 +672,8 @@ static char *hostnqn_read_file(void)
        if (f == NULL)
                return false;
 
-       if (fgets(hostnqn, sizeof(hostnqn), f) == NULL)
+       if (fgets(hostnqn, sizeof(hostnqn), f) == NULL ||
+           !strlen(hostnqn))
                goto out;
 
        ret = strndup(hostnqn, strcspn(hostnqn, "\n"));