]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
RDS: Workaround for in-use MRs on close causing crash
authorAndy Grover <andy.grover@oracle.com>
Tue, 16 Feb 2010 21:54:12 +0000 (13:54 -0800)
committerMukesh Kacker <mukesh.kacker@oracle.com>
Tue, 7 Jul 2015 23:41:21 +0000 (16:41 -0700)
if a machine is shut down without closing sockets properly, and
freeing all MRs, then a BUG_ON will bring it down. This patch
changes these to WARN_ONs -- leaking MRs is not fatal (although
not ideal, and there is more work to do here for a proper fix.)

Signed-off-by: Andy Grover <andy.grover@oracle.com>
net/rds/ib_rdma.c

index c5e916598c14bd950f8a3d4a6b89cdb567389cb6..0ae87ecb850ca8a9a5ca15971b61ffd81cec5f25 100644 (file)
@@ -234,8 +234,8 @@ void rds_ib_destroy_mr_pool(struct rds_ib_mr_pool *pool)
 {
        flush_workqueue(rds_wq);
        rds_ib_flush_mr_pool(pool, 1);
-       BUG_ON(atomic_read(&pool->item_count));
-       BUG_ON(atomic_read(&pool->free_pinned));
+       WARN_ON(atomic_read(&pool->item_count));
+       WARN_ON(atomic_read(&pool->free_pinned));
        kfree(pool);
 }