]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
proc/softirqs: replace seq_printf with seq_put_decimal_ull_width
authorDavid Wang <00107082@163.com>
Wed, 6 Nov 2024 02:12:28 +0000 (10:12 +0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 7 Nov 2024 17:40:14 +0000 (07:40 -1000)
seq_printf is costy, on a system with n CPUs, reading /proc/softirqs
would yield 10*n decimal values, and the extra cost parsing format string
grows linearly with number of cpus. Replace seq_printf with
seq_put_decimal_ull_width have significant performance improvement.
On an 8CPUs system, reading /proc/softirqs show ~40% performance
gain with this patch.

Signed-off-by: David Wang <00107082@163.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/softirqs.c

index f4616083faef3bbb9e00e64d212d67cd650d2a1c..04bb29721419b03f27960d77b13a2e430ac238cb 100644 (file)
@@ -20,7 +20,7 @@ static int show_softirqs(struct seq_file *p, void *v)
        for (i = 0; i < NR_SOFTIRQS; i++) {
                seq_printf(p, "%12s:", softirq_to_name[i]);
                for_each_possible_cpu(j)
-                       seq_printf(p, " %10u", kstat_softirqs_cpu(i, j));
+                       seq_put_decimal_ull_width(p, " ", kstat_softirqs_cpu(i, j), 10);
                seq_putc(p, '\n');
        }
        return 0;