]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 13 Aug 2024 11:32:09 +0000 (12:32 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 13 Aug 2024 11:43:00 +0000 (13:43 +0200)
The driver doesn't create any ALSA controls for firmware controls, so it
shouldn't be calling hda_cs_dsp_control_remove().

commit 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for
firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
didn't remove the call for destroying those controls.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 312c04cee408 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients")
Link: https://patch.msgid.link/20240813113209.648-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda.c

index 3a92e98da72d2495cbfb43c2bda7b400d12227b7..d68bf7591d90c19a601499d9c20612d8c1a12603 100644 (file)
@@ -134,7 +134,7 @@ static const struct reg_sequence cs35l41_hda_mute[] = {
 };
 
 static const struct cs_dsp_client_ops client_ops = {
-       .control_remove = hda_cs_dsp_control_remove,
+       /* cs_dsp requires the client to provide this even if it is empty */
 };
 
 static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *tuning_filename,