mm: pass pvec directly to find_get_entries

All callers of find_get_entries() use a pvec, so pass it directly instead
of manipulating it in the caller.

Link: https://lkml.kernel.org/r/20201112212641.27837-14-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index f837eed042e315d0b20605279766517576499220..f18857c7947827eaca35398c1017160f03539298 100644 (file)
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -451,8 +451,7 @@ static inline struct page *find_subpage(struct page *head, pgoff_t index)
 }
 
 unsigned find_get_entries(struct address_space *mapping, pgoff_t start,
-               pgoff_t end, unsigned int nr_entries, struct page **entries,
-               pgoff_t *indices);
+               pgoff_t end, struct pagevec *pvec, pgoff_t *indices);
 unsigned find_get_pages_range(struct address_space *mapping, pgoff_t *start,
                        pgoff_t end, unsigned int nr_pages,
                        struct page **pages);

diff --git a/mm/filemap.c b/mm/filemap.c
index 045c6b169bc27fa794ef0e2f4a888bcfdd609f95..994bc0c2b4ed6c963b9f59e4e38043e61e21d8be 100644 (file)
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1879,14 +1879,12 @@ reset:
  * @mapping:   The address_space to search
  * @start:     The starting page cache index
  * @end:       The final page index (inclusive).
- * @nr_entries:        The maximum number of entries
- * @entries:   Where the resulting entries are placed
+ * @pvec:      Where the resulting entries are placed.
  * @indices:   The cache indices corresponding to the entries in @entries
  *
- * find_get_entries() will search for and return a group of up to
- * @nr_entries entries in the mapping.  The entries are placed at
- * @entries.  find_get_entries() takes a reference against any actual
- * pages it returns.
+ * find_get_entries() will search for and return a batch of entries in
+ * the mapping.  The entries are placed in @pvec.  find_get_entries()
+ * takes a reference on any actual pages it returns.
  *
  * The search returns a group of mapping-contiguous page cache entries
  * with ascending indexes.  There may be holes in the indices due to
@@ -1903,15 +1901,12 @@ reset:
  * Return: the number of pages and shadow entries which were found.
  */
 unsigned find_get_entries(struct address_space *mapping, pgoff_t start,
-               pgoff_t end, unsigned int nr_entries, struct page **entries,
-               pgoff_t *indices)
+               pgoff_t end, struct pagevec *pvec, pgoff_t *indices)
 {
        XA_STATE(xas, &mapping->i_pages, start);
        struct page *page;
        unsigned int ret = 0;
-
-       if (!nr_entries)
-               return 0;
+       unsigned nr_entries = PAGEVEC_SIZE;
 
        rcu_read_lock();
        while ((page = find_get_entry(&xas, end, XA_PRESENT))) {
@@ -1926,11 +1921,13 @@ unsigned find_get_entries(struct address_space *mapping, pgoff_t start,
                }
 
                indices[ret] = xas.xa_index;
-               entries[ret] = page;
+               pvec->pages[ret] = page;
                if (++ret == nr_entries)
                        break;
        }
        rcu_read_unlock();
+
+       pvec->nr = ret;
        return ret;
 }
 

diff --git a/mm/shmem.c b/mm/shmem.c
index ce36ffb1837d29965aa53614497450bbbab1cfb6..168dc127424164b16201d3a5ab64d568e5926b4e 100644 (file)
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -965,9 +965,8 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend,
        while (index < end) {
                cond_resched();
 
-               pvec.nr = find_get_entries(mapping, index, end - 1,
-                               PAGEVEC_SIZE, pvec.pages, indices);
-               if (!pvec.nr) {
+               if (!find_get_entries(mapping, index, end - 1, &pvec,
+                               indices)) {
                        /* If all gone or hole-punch or unfalloc, we're done */
                        if (index == start || end != -1)
                                break;

diff --git a/mm/swap.c b/mm/swap.c
index 43f36e7e04593f452eb25487fbe207ef8bafdeae..6cc98e5d61d7ed9ccd69a9b46a5c10ae25fe60b6 100644 (file)
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -1060,9 +1060,7 @@ unsigned pagevec_lookup_entries(struct pagevec *pvec,
                struct address_space *mapping, pgoff_t start, pgoff_t end,
                pgoff_t *indices)
 {
-       pvec->nr = find_get_entries(mapping, start, end, PAGEVEC_SIZE,
-                                   pvec->pages, indices);
-       return pagevec_count(pvec);
+       return find_get_entries(mapping, start, end, pvec, indices);
 }
 
 /**